Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve v0.18.1 MPI/HDF5 issue #190

Merged
merged 6 commits into from
Dec 14, 2022
Merged

Resolve v0.18.1 MPI/HDF5 issue #190

merged 6 commits into from
Dec 14, 2022

Conversation

rbberger
Copy link
Collaborator

@rbberger rbberger commented Nov 4, 2022

PR Summary

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @ktsai7 approves, I do too.

@ktsai7
Copy link
Contributor

ktsai7 commented Nov 5, 2022

@rbberger can we wait on this for a little bit? After I merged in the change to update spack to v0.18.1 for the project spack, it's best to just leave both SINGULARITY_EOS_TEMP_SPACK_VERSION and SINGULARITY_EOS_TEMP_SPACK_DIR empty and it should use the project spack version and directory automatically.

@rbberger
Copy link
Collaborator Author

rbberger commented Nov 5, 2022

Sure. This one was just to show that the one remaining issue you mentioned is resolved if you bump the OpenMPI version.

.gitlab-ci.yml Outdated Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator

What is the status of this? Is it still needed? And is it still on hold? If it's on hold, let's change to WIP for now.

@Yurlungur Yurlungur changed the title Resolve v0.18.1 MPI/HDF5 issue WIP: Resolve v0.18.1 MPI/HDF5 issue Dec 14, 2022
@ktsai7
Copy link
Contributor

ktsai7 commented Dec 14, 2022

@Yurlungur this should be ready to go

@Yurlungur Yurlungur changed the title WIP: Resolve v0.18.1 MPI/HDF5 issue Resolve v0.18.1 MPI/HDF5 issue Dec 14, 2022
@Yurlungur Yurlungur merged commit 3dd8fd2 into main Dec 14, 2022
@Yurlungur Yurlungur deleted the rberger_ci_debug branch December 14, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants